• Yonghong Song's avatar
    selftests/bpf: Fix probe_user test failure with clang build kernel · 38261f36
    Yonghong Song authored
    clang build kernel failed the selftest probe_user.
      $ ./test_progs -t probe_user
      $ ...
      $ test_probe_user:PASS:get_kprobe_res 0 nsec
      $ test_probe_user:FAIL:check_kprobe_res wrong kprobe res from probe read: 0.0.0.0:0
      $ #94 probe_user:FAIL
    
    The test attached to kernel function __sys_connect(). In net/socket.c, we have
      int __sys_connect(int fd, struct sockaddr __user *uservaddr, int addrlen)
      {
            ......
      }
      ...
      SYSCALL_DEFINE3(connect, int, fd, struct sockaddr __user *, uservaddr,
                      int, addrlen)
      {
            return __sys_connect(fd, uservaddr, addrlen);
      }
    
    The gcc compiler (8.5.0) does not inline __sys_connect() in syscall entry
    function. But latest clang trunk did the inlining. So the bpf program
    is not triggered.
    
    To make the test more reliable, let us kprobe the syscall entry function
    instead. Note that x86_64, arm64 and s390 have syscall wrappers and they have
    to be handled specially.
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
    Link: https://lore.kernel.org/bpf/20210929033000.3711921-1-yhs@fb.com
    38261f36
probe_user.c 2.13 KB