• Arnd Bergmann's avatar
    netfilter: nfnetlink_log: work around uninitialized variable warning · c872a2d9
    Arnd Bergmann authored
    After a recent (correct) change, gcc started warning about the use
    of the 'flags' variable in nfulnl_recv_config()
    
    net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config':
    net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
    net/netfilter/nfnetlink_log.c:828:6: note: 'flags' was declared here
    
    The warning first shows up in ARM s3c2410_defconfig with gcc-4.3 or
    higher (including 5.2.1, which is the latest version I checked) I
    tried working around it by rearranging the code but had no success
    with that.
    
    As a last resort, this initializes the variable to zero, which shuts
    up the warning, but means that we don't get a warning if the code
    is ever changed in a way that actually causes the variable to be
    used without first being written.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Fixes: 8cbc8708 ("netfilter: nfnetlink_log: validate dependencies to avoid breaking atomicity")
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    c872a2d9
nfnetlink_log.c 27.8 KB