• Martin Blumenstingl's avatar
    clk: meson: mpll: use 64-bit maths in params_from_rate · 86aacdca
    Martin Blumenstingl authored
    "rem * SDM_DEN" can easily overflow on the 32-bit Meson8 and Meson8b
    SoCs if the "remainder" (after the division operation) is greater than
    262143Hz. This is likely to happen since the input clock for the MPLLs
    on Meson8 and Meson8b is "fixed_pll", which is running at a rate of
    2550MHz.
    
    One example where this was observed to be problematic was the Ethernet
    clock calculation (which takes MPLL2 as input). When requesting a rate
    of 125MHz there is a remainder of 2500000Hz.
    The resulting MPLL2 rate before this patch was 127488329Hz.
    The resulting MPLL2 rate after this patch is 124999103Hz.
    
    Commit b609338b ("clk: meson: mpll: use 64bit math in
    rate_from_params") already fixed a similar issue in rate_from_params.
    
    Fixes: 007e6e5c ("clk: meson: mpll: add rw operation")
    Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
    Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    86aacdca
clk-mpll.c 6.71 KB