• David Howells's avatar
    rxrpc: Enable IPv6 checksums on transport socket · 39cb9faa
    David Howells authored
    AF_RXRPC doesn't currently enable IPv6 UDP Tx checksums on the transport
    socket it opens and the checksums in the packets it generates end up 0.
    
    It probably should also enable IPv6 UDP Rx checksums and IPv4 UDP
    checksums.  The latter only seem to be applied if the socket family is
    AF_INET and don't seem to apply if it's AF_INET6.  IPv4 packets from an
    IPv6 socket seem to have checksums anyway.
    
    What seems to have happened is that the inet_inv_convert_csum() call didn't
    get converted to the appropriate udp_port_cfg parameters - and
    udp_sock_create() disables checksums unless explicitly told not too.
    
    Fix this by enabling the three udp_port_cfg checksum options.
    
    Fixes: 1a9b86c9 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
    Reported-by: default avatarMarc Dionne <marc.dionne@auristor.com>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Reviewed-by: default avatarXin Long <lucien.xin@gmail.com>
    Reviewed-by: default avatarMarc Dionne <marc.dionne@auristor.com>
    cc: Vadim Fedorenko <vfedorenko@novek.ru>
    cc: David S. Miller <davem@davemloft.net>
    cc: linux-afs@lists.infradead.org
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    39cb9faa
local_object.c 11.3 KB