• Sebastian Andrzej Siewior's avatar
    x86/mcheck: Reorganize the hotplug callbacks · 39f152ff
    Sebastian Andrzej Siewior authored
    Initially I wanted to remove mcheck_cpu_init() from identify_cpu() and let it
    become an independent early hotplug callback. The main problem here was that
    the init on the boot CPU may happen too late
    (device_initcall_sync(mcheck_init_device)) and nobody wanted to risk receiving
    and MCE event at boot time leading to a shutdown (if the MCE feature is not yet
    enabled).
    
    Here is attempt two: the timming stays as-is but the ordering of the functions
    is changed:
    - mcheck_cpu_init() (which is run from identify_cpu()) will setup the timer
      struct but won't fire the timer. This is moved to CPU_ONLINE since its
      cleanup part is in CPU_DOWN_PREPARE. So if it is okay to stop the timer early
      in the shutdown phase, it should be okay to start it late in the bring up phase.
    
    - CPU_DOWN_PREPARE disables the MCE feature flags for !INTEL CPUs in
      mce_disable_cpu(). If a failure occures it would be re-enabled on all vendor
      CPUs (including Intel where it was not disabled during shutdown). To keep this
      working I am moving it to CPU_ONLINE. smp_call_function_single() is dropped
      beause the notifier runs nowdays on the target CPU.
    
    - CPU_ONLINE is invoking mce_device_create() + mce_threshold_create_device()
      but its cleanup part is in CPU_DEAD (mce_threshold_remove_device() and
      mce_device_remove()). In order to keep this symmetrical I am moving the clean
      up from CPU_DEAD to CPU_DOWN_PREPARE.
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Acked-by: default avatarBorislav Petkov <bp@alien8.de>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: rt@linutronix.de
    Cc: linux-edac@vger.kernel.org
    Link: http://lkml.kernel.org/r/20161110174447.11848-6-bigeasy@linutronix.deSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    39f152ff
mce.c 61.9 KB