• Matthias Reichl's avatar
    ASoC: hdmi-codec: Fix broken channel map reporting · b84b5314
    Matthias Reichl authored
    Commit 4e087133 ("ASoC: hdmi-codec: fix channel info for
    compressed formats") accidentally changed hcp->chmap_idx from
    ca_id, the CEA channel allocation ID, to idx, the index to
    the table of channel mappings ordered by preference.
    
    This resulted in wrong channel maps being reported to userspace,
    eg for 5.1 "FL,FR,LFE,FC" was reported instead of the expected
    "FL,FR,LFE,FC,RL,RR":
    
    ~ # speaker-test -c 6 -t sine
    ...
     0 - Front Left
     3 - Front Center
     1 - Front Right
     2 - LFE
     4 - Unknown
     5 - Unknown
    
    ~ # amixer cget iface=PCM,name='Playback Channel Map' | grep ': values'
      : values=3,4,8,7,0,0,0,0
    
    Switch this back to ca_id in case of PCM audio so the correct channel
    map is reported again and set it to HDMI_CODEC_CHMAP_IDX_UNKNOWN in
    case of non-PCM audio so the PCM channel map control returns "Unknown"
    channels (value 0).
    
    Fixes: 4e087133 ("ASoC: hdmi-codec: fix channel info for compressed formats")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarMatthias Reichl <hias@horus.com>
    Link: https://lore.kernel.org/r/20230929195027.97136-1-hias@horus.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    b84b5314
hdmi-codec.c 30.5 KB