• Arnd Bergmann's avatar
    drm/nouveau: nouveau: use larger buffer in nvif_vmm_map · 9dfbd731
    Arnd Bergmann authored
    gcc points out a buffer that is clearly too small to be used
    in a meaningful way, as the 'sizeof(*args) + argc > sizeof(stack)'
    will always fail:
    
    In function 'memcpy',
        inlined from 'nvif_vmm_map' at drivers/gpu/drm/nouveau/nvif/vmm.c:55:2:
    include/linux/string.h:353:9: error: '__builtin_memcpy' offset 40 is out of the bounds [0, 16] of object 'stack' with type 'u8[16]' {aka 'unsigned char[16]'} [-Werror=array-bounds]
      return __builtin_memcpy(p, q, size);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/gpu/drm/nouveau/nvif/vmm.c: In function 'nvif_vmm_map':
    drivers/gpu/drm/nouveau/nvif/vmm.c:40:5: note: 'stack' declared here
    
    This makes the buffer large enough so it should serve the purpose
    that the author presumably had in mind. Alternatively we could
    just get rid of it completely and simplify the code at the cost
    of always doing the kmalloc (as we do in the current version).
    
    Fixes: 920d2b5e ("drm/nouveau/mmu: define user interfaces to mmu vmm opertaions")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
    9dfbd731
vmm.c 4.17 KB