• Nicholas Piggin's avatar
    mm/vmalloc: huge vmalloc backing pages should be split rather than compound · 3b8000ae
    Nicholas Piggin authored
    Huge vmalloc higher-order backing pages were allocated with __GFP_COMP
    in order to allow the sub-pages to be refcounted by callers such as
    "remap_vmalloc_page [sic]" (remap_vmalloc_range).
    
    However a similar problem exists for other struct page fields callers
    use, for example fb_deferred_io_fault() takes a vmalloc'ed page and
    not only refcounts it but uses ->lru, ->mapping, ->index.
    
    This is not compatible with compound sub-pages, and can cause bad page
    state issues like
    
      BUG: Bad page state in process swapper/0  pfn:00743
      page:(____ptrval____) refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x743
      flags: 0x7ffff000000000(node=0|zone=0|lastcpupid=0x7ffff)
      raw: 007ffff000000000 c00c00000001d0c8 c00c00000001d0c8 0000000000000000
      raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
      page dumped because: corrupted mapping in tail page
      Modules linked in:
      CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.18.0-rc3-00082-gfc6fff4a7ce1-dirty #2810
      Call Trace:
        dump_stack_lvl+0x74/0xa8 (unreliable)
        bad_page+0x12c/0x170
        free_tail_pages_check+0xe8/0x190
        free_pcp_prepare+0x31c/0x4e0
        free_unref_page+0x40/0x1b0
        __vunmap+0x1d8/0x420
        ...
    
    The correct approach is to use split high-order pages for the huge
    vmalloc backing. These allow callers to treat them in exactly the same
    way as individually-allocated order-0 pages.
    
    Link: https://lore.kernel.org/all/14444103-d51b-0fb3-ee63-c3f182f0b546@molgen.mpg.de/Signed-off-by: default avatarNicholas Piggin <npiggin@gmail.com>
    Cc: Paul Menzel <pmenzel@molgen.mpg.de>
    Cc: Song Liu <songliubraving@fb.com>
    Cc: Rick Edgecombe <rick.p.edgecombe@intel.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    3b8000ae
vmalloc.c 107 KB