• Linus Torvalds's avatar
    x86-64: make csum_partial_copy_from_user() error handling consistent · 3b91270a
    Linus Torvalds authored
    Al Viro pointed out that the x86-64 csum_partial_copy_from_user() is
    somewhat confused about what it should do on errors, notably it mostly
    clears the uncopied end result buffer, but misses that for the initial
    alignment case.
    
    All users should check for errors, so it's dubious whether the clearing
    is even necessary, and Al also points out that we should probably clean
    up the calling conventions, but regardless of any future changes to this
    function, the fact that it is inconsistent is just annoying.
    
    So make the __get_user() failure path use the same error exit as all the
    other errors do.
    Reported-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    Cc: David Miller <davem@davemloft.net>
    Cc: Andi Kleen <andi@firstfloor.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    3b91270a
csum-wrappers_64.c 3.9 KB