• Tejun Heo's avatar
    workqueue: Don't implicitly make UNBOUND workqueues w/ @max_active==1 ordered · 3bc1e711
    Tejun Heo authored
    5c0338c6 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")
    automoatically promoted UNBOUND workqueues w/ @max_active==1 to ordered
    workqueues because UNBOUND workqueues w/ @max_active==1 used to be the way
    to create ordered workqueues and the new NUMA support broke it. These
    problems can be subtle and the fact that they can only trigger on NUMA
    machines made them even more difficult to debug.
    
    However, overloading the UNBOUND allocation interface this way creates other
    issues. It's difficult to tell whether a given workqueue actually needs to
    be ordered and users that legitimately want a min concurrency level wq
    unexpectedly gets an ordered one instead. With planned UNBOUND workqueue
    udpates to improve execution locality and more prevalence of chiplet designs
    which can benefit from such improvements, this isn't a state we wanna be in
    forever.
    
    There aren't that many UNBOUND w/ @max_active==1 users in the tree and the
    preceding patches audited all and converted them to
    alloc_ordered_workqueue() as appropriate. This patch removes the implicit
    promotion of UNBOUND w/ @max_active==1 workqueues to ordered ones.
    
    v2: v1 patch incorrectly dropped !list_empty(&wq->pwqs) condition in
        apply_workqueue_attrs_locked() which spuriously triggers WARNING and
        fails workqueue creation. Fix it.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
    Link: https://lore.kernel.org/oe-lkp/202304251050.45a5df1f-oliver.sang@intel.com
    3bc1e711
workqueue.c 213 KB