• Arnd Bergmann's avatar
    skd: fix msix error handling · 3bc8492f
    Arnd Bergmann authored
    As reported by gcc -Wmaybe-uninitialized, the cleanup path for
    skd_acquire_msix tries to free the already allocated msi-x vectors
    in reverse order, but the index variable may not have been
    used yet:
    
    drivers/block/skd_main.c: In function ‘skd_acquire_irq’:
    drivers/block/skd_main.c:3890:8: error: ‘i’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    This changes the failure path to skip releasing the interrupts
    if we have not started requesting them yet.
    
    Fixes: 180b0ae7 ("skd: use pci_alloc_irq_vectors")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
    3bc8492f
skd_main.c 134 KB