• Linus Torvalds's avatar
    x86: use proper parentheses around new uaccess macro argument uses · 3beff76b
    Linus Torvalds authored
    __get_kernel_nofault() didn't have the parentheses around the use of
    'src' and 'dst' macro arguments, making the casts potentially do the
    wrong thing.
    
    The parentheses aren't necessary with the current very limited use in
    mm/access.c, but it's bad form, and future use-cases might have very
    unexpected errors as a result.
    
    Do the same for unsafe_copy_loop() while at it, although in that case it
    is an entirely internal x86 uaccess helper macro that isn't used
    anywhere else and any other use would be invalid anyway.
    
    Fixes: fa94111d ("x86: use non-set_fs based maccess routines")
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    3beff76b
uaccess.h 16.2 KB