• J. Bruce Fields's avatar
    Revert "nfsd4: return default lease period" · 3bf6b57e
    J. Bruce Fields authored
    This reverts commit d6ebf508.
    
    I forgot that the kernel's default lease period should never be
    decreased!
    
    After a kernel upgrade, the kernel has no way of knowing on its own what
    the previous lease time was.  Unless userspace tells it otherwise, it
    will assume the previous lease period was the same.
    
    So if we decrease this value in a kernel upgrade, we end up enforcing a
    grace period that's too short, and clients will fail to reclaim state in
    time.  Symptoms may include EIO and log messages like "NFS:
    nfs4_reclaim_open_state: Lock reclaim failed!"
    
    There was no real justification for the lease period decrease anyway.
    Reported-by: default avatarDonald Buczek <buczek@molgen.mpg.de>
    Fixes: d6ebf508 "nfsd4: return default lease period"
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    3bf6b57e
nfsctl.c 33.7 KB