• Arnd Bergmann's avatar
    platform/x86: intel_pmc_core: avoid unused-function warnings · 3ce2db60
    Arnd Bergmann authored
    When both CONFIG_DEBUG_FS and CONFIG_PM_SLEEP are disabled, the
    functions that got moved out of the #ifdef section now cause
    a warning:
    
    drivers/platform/x86/intel_pmc_core.c:654:13: error: 'pmc_core_lpm_display' defined but not used [-Werror=unused-function]
      654 | static void pmc_core_lpm_display(struct pmc_dev *pmcdev, struct device *dev,
          |             ^~~~~~~~~~~~~~~~~~~~
    drivers/platform/x86/intel_pmc_core.c:617:13: error: 'pmc_core_slps0_display' defined but not used [-Werror=unused-function]
      617 | static void pmc_core_slps0_display(struct pmc_dev *pmcdev, struct device *dev,
          |             ^~~~~~~~~~~~~~~~~~~~~~
    
    Rather than add even more #ifdefs here, remove them entirely and
    let the compiler work it out, it can actually get rid of all the
    debugfs calls without problems as long as the struct member is
    there.
    
    The two PM functions just need a __maybe_unused annotations to avoid
    another warning instead of the #ifdef.
    
    Fixes: aae43c2b ("platform/x86: intel_pmc_core: Relocate pmc_core_*_display() to outside of CONFIG_DEBUG_FS")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    3ce2db60
intel_pmc_core.h 9.19 KB