• Matt Redfearn's avatar
    MIPS: Malta: Fix i8259 irqchip setup · 9eec1c01
    Matt Redfearn authored
    Since commit 4cfffcfa ("irqchip/mips-gic: Fix local interrupts"),
    the gic driver has been allocating virq's for local interrupts during
    its initialisation. Unfortunately on Malta platforms, these are the
    first IRQs to be allocated and so are allocated virqs 1-3. The i8259
    driver uses a legacy irq domain which expects to map virqs 0-15. Probing
    of that driver therefore fails because some of those virqs are already
    taken, with the warning:
    
    WARNING: CPU: 0 PID: 0 at kernel/irq/irqdomain.c:344
    irq_domain_associate+0x1e8/0x228
    error: virq1 is already associated
    Modules linked in:
    CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.10.0-rc6-00011-g4cfffcfa #368
    Stack : 00000000 00000000 807ae03a 0000004d 00000000 806c1010 0000000b ffff0a01
            80725467 807258f4 806a64a4 00000000 00000000 807a9acc 00000100 80713e68
            806d5598 8017593c 8072bf90 8072bf94 806ac358 00000000 806abb60 80713ce4
            00000100 801b22d4 806d5598 8017593c 807ae03a 00000000 80713ce4 80720000
            00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
            ...
    Call Trace:
    [<8010c480>] show_stack+0x88/0xa4
    [<80376758>] dump_stack+0x88/0xd0
    [<8012c4a8>] __warn+0x104/0x118
    [<8012c4ec>] warn_slowpath_fmt+0x30/0x3c
    [<8017edfc>] irq_domain_associate+0x1e8/0x228
    [<8017efd0>] irq_domain_add_legacy+0x7c/0xb0
    [<80764c50>] __init_i8259_irqs+0x64/0xa0
    [<80764ca4>] i8259_of_init+0x18/0x74
    [<8076ddc0>] of_irq_init+0x19c/0x310
    [<80752dd8>] arch_init_irq+0x28/0x19c
    [<80750a08>] start_kernel+0x2a8/0x434
    
    Fix this by reserving the required i8259 virqs in malta platform code
    before probing any irq chips.
    
    Fixes: 4cfffcfa ("irqchip/mips-gic: Fix local interrupts")
    Signed-off-by: default avatarMatt Redfearn <matt.redfearn@imgtec.com>
    Cc: James Hogan <james.hogan@imgtec.com>
    Cc: Paul Burton <paul.burton@imgtec.com>
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/15919/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    9eec1c01
malta-int.c 8.1 KB