• Damien Le Moal's avatar
    libata: Cleanup ata_read_log_page() · 7cfdfdc8
    Damien Le Moal authored
    The warning message "READ LOG DMA EXT failed, trying unqueued" in
    ata_read_log_page() as well as the macro name ATA_HORKAGE_NO_NCQ_LOG
    are confusing: the command READ LOG DMA EXT is not an queued NCQ command
    unless it is encapsulated in a RECEIVE FPDMA QUEUED command.
    From ACS-4 READ LOG DMA EXT description:
    
    "The device processes the READ LOG DMA EXT command in the NCQ feature
    set environment (see 4.13.6) if the READ LOG DMA EXT command is
    encapsulated in a RECEIVE FPDMA QUEUED command (see 7.30) with the
    inputs encapsulated as shown in 7.23.6."
    
    To avoid confusion, fix the warning messsage to mention switching to PIO and
    not "unqueued" and rename the macro ATA_HORKAGE_NO_NCQ_LOG to
    ATA_HORKAGE_NO_DMA_LOG.
    Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
    Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    7cfdfdc8
libata-core.c 188 KB