• Julian Braha's avatar
    ASoC: fix unmet dependency on GPIOLIB for SND_SOC_MAX98357A · 3e701151
    Julian Braha authored
    When SND_SOC_INTEL_KBL_DA7219_MAX98357A_MACH is selected,
    and GPIOLIB is not selected, Kbuild gives the
    following warnings:
    
    WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_INTEL_DA7219_MAX98357A_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y]
    
    WARNING: unmet direct dependencies detected for SND_SOC_DMIC
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_INTEL_DA7219_MAX98357A_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y]
    
    WARNING: unmet direct dependencies detected for SND_SOC_INTEL_DA7219_MAX98357A_GENERIC
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_INTEL_KBL_DA7219_MAX98357A_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && SND_SOC_INTEL_KBL [=y] && I2C [=y] && ACPI [=y] && (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n])
    
    This is because SND_SOC_DMIC and SND_SOC_MAX98357A are
    selected by SND_SOC_INTEL_DA7219_MAX98357A_GENERIC, which
    is also selected by SND_SOC_INTEL_KBL_DA7219_MAX98357A_MACH.
    However, the selectors do not depend on or select GPIOLIB,
    despite SND_SOC_DMIC and SND_SOC_MAX98357A depending on GPIOLIB.
    
    These unmet dependency bugs were detected by Kismet,
    a static analysis tool for Kconfig. Please advise if this
    is not the appropriate solution.
    Signed-off-by: default avatarJulian Braha <julianbraha@gmail.com>
    Link: https://lore.kernel.org/r/20211025010615.10070-1-julianbraha@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    3e701151
Kconfig 20.7 KB