• Kei Tokunaga's avatar
    [SCSI] mptsas: fixed hot-removal processing · 3e84beba
    Kei Tokunaga authored
    This patch fixes mptsas disk hot-removal processing.  The
    hot-removal processing doesn't complete because of this condition.
    
      drivers/message/fusion/mptsas.c:
      mptsas_taskmgmt_complete()
    
      if ((mptsas_find_vtarget(ioc, channel, id)) && !ioc->fw_events_off)
        mptsas_queue_device_delete(...);
    
    mptsas_queue_device_delete(), which must be called for
    hot-removal, never gets called because mptsas_find_vtarget()
    always returns 0 here.  At that time, the vtarget has already
    been freed in mptsas_target_destroy(), and also the scsi_device
    has been marked as SDEV_DEL.
    
    As a result of the issue, port deletion functions won't get
    called and the device ends up being in an incomplete state.
    (Some data structures and sysfs entries, which should be
    removed in hot-removal, remain.)  One side effect of this is
    that a hot-addition of the device (bringing the device back
    on) fails.
    
    This patch just removes mptsas_find_vtarget() from the if-state
    condition.
    Signed-off-by: default avatarKei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
    Acked-by: default avatar"Desai, Kashyap" <Kashyap.Desai@lsi.com>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
    3e84beba
mptsas.c 142 KB