• Arnd Bergmann's avatar
    usb: musb: use %pad format string from dma_addr_t · 3ec08ddf
    Arnd Bergmann authored
    The musb driver prints DMA addresses in a few places, using the
    0x%x format string. This is wrong on 64-bit architectures (which
    need %lx) and 32-bit ARM with CONFIG_LPAE set (which needs
    %llx), otherwise we print the wrong data, as gcc warns:
    
    musb/musbhsdma.c: In function 'configure_channel':
    musb/musbhsdma.c:120:53: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t {aka long long unsigned int}' [-Werror=format=]
      dev_dbg(musb->controller, "%p, pkt_sz %d, addr 0x%x, len %d, mode %d\n",
    musb/musbhsdma.c: In function 'dma_channel_program':
    musb/musbhsdma.c:155:53: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'dma_addr_t {aka long long unsigned int}' [-Werror=format=]
      dev_dbg(musb->controller, "ep%d-%s pkt_sz %d, dma_addr 0x%x length %d, mode %d\n",
    musb/tusb6010_omap.c: In function 'tusb_omap_dma_program':
    musb/tusb6010_omap.c:313:53: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'dma_addr_t {aka long long unsigned int}' [-Werror=format=]
      dev_dbg(musb->controller, "ep%i %s dma ch%i dma: %08x len: %u(%u) packet_sz: %i(%i)\n",
    
    This uses the %pad format string, which prints a dma_addr_t that
    gets passed by reference, which works for all combinations.
    Acked-by: default avatarTony Lindgren <tony@atomide.com>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
    3ec08ddf
musbhsdma.c 11.6 KB