• James Cowgill's avatar
    KVM: MIPS: Fix maybe-uninitialized build failure · e27a9eca
    James Cowgill authored
    This commit fixes a "maybe-uninitialized" build failure in
    arch/mips/kvm/tlb.c when KVM, DYNAMIC_DEBUG and JUMP_LABEL are all
    enabled. The failure is:
    
    In file included from ./include/linux/printk.h:329:0,
                     from ./include/linux/kernel.h:13,
                     from ./include/asm-generic/bug.h:15,
                     from ./arch/mips/include/asm/bug.h:41,
                     from ./include/linux/bug.h:4,
                     from ./include/linux/thread_info.h:11,
                     from ./include/asm-generic/current.h:4,
                     from ./arch/mips/include/generated/asm/current.h:1,
                     from ./include/linux/sched.h:11,
                     from arch/mips/kvm/tlb.c:13:
    arch/mips/kvm/tlb.c: In function ‘kvm_mips_host_tlb_inv’:
    ./include/linux/dynamic_debug.h:126:3: error: ‘idx_kernel’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
       __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
       ^~~~~~~~~~~~~~~~~~
    arch/mips/kvm/tlb.c:169:16: note: ‘idx_kernel’ was declared here
      int idx_user, idx_kernel;
                    ^~~~~~~~~~
    
    There is a similar error relating to "idx_user". Both errors were
    observed with GCC 6.
    
    As far as I can tell, it is impossible for either idx_user or idx_kernel
    to be uninitialized when they are later read in the calls to kvm_debug,
    but to satisfy the compiler, add zero initializers to both variables.
    Signed-off-by: default avatarJames Cowgill <James.Cowgill@imgtec.com>
    Fixes: 57e3869c ("KVM: MIPS/TLB: Generalise host TLB invalidate to kernel ASID")
    Cc: <stable@vger.kernel.org> # 4.11+
    Acked-by: default avatarJames Hogan <james.hogan@imgtec.com>
    Signed-off-by: default avatarRadim Krčmář <rkrcmar@redhat.com>
    e27a9eca
tlb.c 16.4 KB