• Fenghua Yu's avatar
    x86/fpu: Clear PASID when copying fpstate · dc7507dd
    Fenghua Yu authored
    The kernel must allocate a Process Address Space ID (PASID) on behalf of
    each process which will use ENQCMD and program it into the new MSR to
    communicate the process identity to platform hardware. ENQCMD uses the
    PASID stored in this MSR to tag requests from this process.
    
    The PASID state must be cleared on fork() since fork creates a
    new address space.
    
    For clone(), it would be functionally OK to copy the PASID. However,
    clearing it is _also_ functionally OK since any PASID use will trigger
    the #GP handler to populate the MSR.
    
    Copying the PASID state has two main downsides:
     * It requires differentiating fork() and clone() in the code,
       both in the FPU code and keeping tsk->pasid_activated consistent.
     * It guarantees that the PASID is out of its init state, which
       incurs small but non-zero cost on every XSAVE/XRSTOR.
    
    The main downside of clearing the PASID at fpstate copy is the future,
    one-time #GP for the thread.
    
    Use the simplest approach: clear the PASID state both on clone() and
    fork().  Rely on the #GP handler for MSR population in children.
    
    Also, just clear the PASID bit from xfeatures if XSAVE is supported.
    This will have no effect on systems that do not have PASID support.  It
    is virtually zero overhead because 'dst_fpu' was just written and
    the whole thing is cache hot.
    Signed-off-by: default avatarFenghua Yu <fenghua.yu@intel.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Reviewed-by: default avatarTony Luck <tony.luck@intel.com>
    Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/20220207230254.3342514-7-fenghua.yu@intel.com
    dc7507dd
core.c 22.7 KB