• Benjamin Marzinski's avatar
    gfs2: clear journal live bit in gfs2_log_flush · 400ac52e
    Benjamin Marzinski authored
    When gfs2 was unmounting filesystems or changing them to read-only it
    was clearing the SDF_JOURNAL_LIVE bit before the final log flush.  This
    caused a race.  If an inode glock got demoted in the gap between
    clearing the bit and the shutdown flush, it would be unable to reserve
    log space to clear out the active items list in inode_go_sync, causing an
    error in inode_go_inval because the glock was still dirty.
    
    To solve this, the SDF_JOURNAL_LIVE bit is now cleared inside the
    shutdown log flush.  This means that, because of the locking on the log
    blocks, either inode_go_sync will be able to reserve space to clean the
    glock before the shutdown flush, or the shutdown flush will clean the
    glock itself, before inode_go_sync fails to reserve the space. Either
    way, the glock will be clean before inode_go_inval.
    Signed-off-by: default avatarBenjamin Marzinski <bmarzins@redhat.com>
    Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
    400ac52e
log.c 25 KB