• Hans Verkuil's avatar
    [media] vb2: fix handling of data_offset and v4l2_plane.reserved[] · 412376a1
    Hans Verkuil authored
    The videobuf2-core did not zero the 'planes' array in __qbuf_userptr()
    and __qbuf_dmabuf(). That's now memset to 0. Without this the reserved
    array in struct v4l2_plane would be non-zero, causing v4l2-compliance
    errors.
    
    More serious is the fact that data_offset was not handled correctly:
    
    - for capture devices it was never zeroed, which meant that it was
      uninitialized. Unless the driver sets it it was a completely random
      number. With the memset above this is now fixed.
    
    - __qbuf_dmabuf had a completely incorrect length check that included
      data_offset.
    
    - in __fill_vb2_buffer in the DMABUF case the data_offset field was
      unconditionally copied from v4l2_buffer to v4l2_plane when this
      should only happen in the output case.
    
    - in the single-planar case data_offset was never correctly set to 0.
      The single-planar API doesn't support data_offset, so setting it
      to 0 is the right thing to do. This too is now solved by the memset.
    
    All these issues were found with v4l2-compliance.
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Acked-by: default avatarPawel Osciak <pawel@osciak.com>
    Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    412376a1
videobuf2-core.c 87.9 KB