• rene.scharfe@lsrfire.ath.cx's avatar
    [PATCH] remove mount option parsing from procfs · 414d718a
    rene.scharfe@lsrfire.ath.cx authored
    This patch removes the mount options of the proc filesystem.  They don't
    have any effect since 2.4.something.
    
    Only proc_fill_super() calls parse_options, notably proc_remount() does
    not.  And proc_fill_super() is only called at the very first mount which in
    turn is the one caused by kern_mount() in fs/proc/root.c and that passes a
    NULL pointer as mount options string.  It is called only once because proc
    is a filesystem with a single super_block (i.e.  it uses get_sb_single()).
    
    Since noone seems to miss the uid and gid options so far I suggest to
    simply remove them.  Their function can be easily performed in userspace.
    E.g.  this (if it worked like intended):
    
        # mount -t proc -o uid=procuser,gid=procgrp proc /proc
    
    can be done like so, probably in some init script:
    
        # mount -t proc proc /proc && chown procuser:procgrp /proc
    
    But I don't see why anyone would want to do that in the first place.
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    414d718a
inode.c 4.47 KB