• Su Yue's avatar
    ocfs2: enable ocfs2_listxattr for special files · 41e296f6
    Su Yue authored
    For special files in S_IFBLK/S_IFCHR/S_IFIFO type, we already have
    ocfs2_setattr and ocfs2_getattr enabled.  It's confusing for user space if
    it can use setattr/getattr to control one attribute appointed but can not
    list attributes using listxattr for above type files:
    
    $ mknod /mnt/b b 0 0
    $ setfattr -h -n trusted.name -v 0xbabe /mnt/b
    $ getfattr -n trusted.name  /mnt/b
    getfattr: Removing leading '/' from absolute path names
    trusted.name=0sur4=
    
    $ getfattr -m trusted  /mnt/b
    $
    
    Fix it by enabling ocfs2_listxattr for ocfs2_special_file_iops.  After the
    commit, fstests/generic/062 will pass.
    
    Link: https://lkml.kernel.org/r/20240312042908.8889-1-l@damenly.orgSigned-off-by: default avatarSu Yue <glass.su@suse.com>
    Acked-by: default avatarJoseph Qi <joseph.qi@linux.alibaba.com>
    Cc: Mark Fasheh <mark@fasheh.com>
    Cc: Joel Becker <jlbec@evilplan.org>
    Cc: Junxiao Bi <junxiao.bi@oracle.com>
    Cc: Changwei Ge <gechangwei@live.cn>
    Cc: Gang He <ghe@suse.com>
    Cc: Jun Piao <piaojun@huawei.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    41e296f6
file.c 70.1 KB