• Michael Chan's avatar
    bnxt_en: Fix bnxt_reinit_after_abort() code path · 4279414b
    Michael Chan authored
    bnxt_reinit_after_abort() is called during ifup when a previous
    FW reset sequence has aborted or a previous ifup has failed after
    detecting FW reset.  In all cases, it is safe to assume that a
    previous FW reset has completed and the driver may not have fully
    reinitialized.
    
    Prior to this patch, it is assumed that the
    FUNC_DRV_IF_CHANGE_RESP_FLAGS_HOT_FW_RESET_DONE flag will always be
    set by the firmware in bnxt_hwrm_if_change().  This may not be true if
    the driver has already attempted to register with the firmware.  The
    firmware may not set the RESET_DONE flag again after the driver has
    registered, assuming that the driver has seen the flag already.
    
    Fix it to always go through the FW reset initialization path if
    the BNXT_STATE_FW_RESET_DET flag is set.  This flag is always set
    by the driver after successfully going through bnxt_reinit_after_abort().
    
    Fixes: 6882c36c ("bnxt_en: attempt to reinitialize after aborted reset")
    Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
    Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    4279414b
bnxt.c 363 KB