• Stephen Boyd's avatar
    msm_serial: Use devm_clk_get() and properly return errors · 519b371d
    Stephen Boyd authored
    Clocks are not clk_put() in this driver's error paths during
    probe. The code that checks for clock errors also fails to
    properly return the error code from the pclk member if it turns
    out to be the failing clock, leading to potentially confusing
    error values if the clk member is not an error pointer. Fix these
    problems with devm_clk_get() and proper error checking.
    
    Removing the clk_put() in msm_serial_remove() also points out
    that msm_port is unused. Furthermore, msm_port is the wrong type
    and so the clk_put() would be using the wrong pointer. Replace it
    with the proper type and call uart_remove_one_port() to do the
    proper cleanup.
    
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarDavid Brown <davidb@codeaurora.org>
    519b371d
msm_serial.c 22.5 KB