• Jason A. Donenfeld's avatar
    net: always use icmp{,v6}_ndo_send from ndo_start_xmit · 4372339e
    Jason A. Donenfeld authored
    There were a few remaining tunnel drivers that didn't receive the prior
    conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to
    memory corrution (see ee576c47 ("net: icmp: pass zeroed opts from
    icmp{,v6}_ndo_send before sending") for details), there's even more
    imperative to have these all converted. So this commit goes through the
    remaining cases that I could find and does a boring translation to the
    ndo variety.
    
    The Fixes: line below is the merge that originally added icmp{,v6}_
    ndo_send and converted the first batch of icmp{,v6}_send users. The
    rationale then for the change applies equally to this patch. It's just
    that these drivers were left out of the initial conversion because these
    network devices are hiding in net/ rather than in drivers/net/.
    
    Cc: Florian Westphal <fw@strlen.de>
    Cc: Willem de Bruijn <willemb@google.com>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
    Cc: David Ahern <dsahern@kernel.org>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Steffen Klassert <steffen.klassert@secunet.com>
    Fixes: 803381f9 ("Merge branch 'icmp-account-for-NAT-when-sending-icmps-from-ndo-layer'")
    Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
    Acked-by: default avatarWillem de Bruijn <willemb@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4372339e
ip_tunnel.c 29.4 KB