• Jani Nikula's avatar
    drm/i915: use pch backlight override on hsw too · 437b15b8
    Jani Nikula authored
    Currently the difference between backlight control on HSW vs. BDW/SKL is
    that on HSW we modify the duty cycle on the CPU register, and have the
    hardware pass the changes on to the PCH registers. We still drive the
    PCH PWM on both. While HSW and BDW use the same LPT PCH, BDW does not
    pass these messages on to the PCH. Therefore on BDW we need to enable
    the PCH override bit, and program the PCH directly. (On SPT PCH, this
    mode is the default.) We could as well do this on HSW too, and in fact
    I've been told this is what a certain other operating system does. So
    use PCH backlight override on HSW too.
    
    This simplifies some follow-up code, but it does have the danger of
    breaking backlight on HSW machines. It should work, but mysterious are
    the ways of backlight.
    
    While at it, name the related backlight hooks according to the PCH
    rather than the CPU for clarity.
    
    Cc: Clint Taylor <clinton.a.taylor@intel.com>
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Reviewed-by: default avatarClint Taylor <Clinton.A.Taylor@intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    437b15b8
intel_panel.c 47.3 KB