• Thomas Hebb's avatar
    drm/rockchip: dsi: move all lane config except LCDC mux to bind() · 43c2de10
    Thomas Hebb authored
    When we first enable the DSI encoder, we currently program some per-chip
    configuration that we look up in rk3399_chip_data based on the device
    tree compatible we match. This data configures various parameters of the
    MIPI lanes, including on RK3399 whether DSI1 is slaved to DSI0 in a
    dual-mode configuration. It also selects which LCDC (i.e. VOP) to scan
    out from.
    
    This causes a problem in RK3399 dual-mode configurations, though: panel
    prepare() callbacks run before the encoder gets enabled and expect to be
    able to write commands to the DSI bus, but the bus isn't fully
    functional until the lane and master/slave configuration have been
    programmed. As a result, dual-mode panels (and possibly others too) fail
    to turn on when the rockchipdrm driver is initially loaded.
    
    Because the LCDC mux is the only thing we don't know until enable time
    (and is the only thing that can ever change), we can actually move most
    of the initialization to bind() and get it out of the way early. That's
    what this change does. (Rockchip's 4.4 BSP kernel does it in mode_set(),
    which also avoids the issue, but bind() seems like the more correct
    place to me.)
    
    Tested on a Google Scarlet board (Acer Chromebook Tab 10), which has a
    Kingdisplay KD097D04 dual-mode panel. Prior to this change, the panel's
    backlight would turn on but no image would appear when initially loading
    rockchipdrm. If I kept rockchipdrm loaded and reloaded the panel driver,
    it would come on. With this change, the panel successfully turns on
    during initial rockchipdrm load as expected.
    
    Fixes: 2d4f7bda ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver")
    Signed-off-by: default avatarThomas Hebb <tommyhebb@gmail.com>
    Tested-by: default avatarJonathan Liu <net147@gmail.com>
    Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/55fe7f3454d8c91dc3837ba5aa741d4a0e67378f.1618797813.git.tommyhebb@gmail.com
    43c2de10
dw-mipi-dsi-rockchip.c 33.8 KB