• Xiyu Yang's avatar
    tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv · 441870ee
    Xiyu Yang authored
    tipc_crypto_rcv() invokes tipc_aead_get(), which returns a reference of
    the tipc_aead object to "aead" with increased refcnt.
    
    When tipc_crypto_rcv() returns, the original local reference of "aead"
    becomes invalid, so the refcount should be decreased to keep refcount
    balanced.
    
    The issue happens in one error path of tipc_crypto_rcv(). When TIPC
    message decryption status is EINPROGRESS or EBUSY, the function forgets
    to decrease the refcnt increased by tipc_aead_get() and causes a refcnt
    leak.
    
    Fix this issue by calling tipc_aead_put() on the error path when TIPC
    message decryption status is EINPROGRESS or EBUSY.
    Signed-off-by: default avatarXiyu Yang <xiyuyang19@fudan.edu.cn>
    Signed-off-by: default avatarXin Tan <tanxin.ctf@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    441870ee
crypto.c 52.6 KB