• Giedrius Statkevičius's avatar
    platform/x86: asus-laptop: get rid of parse_arg() · 6f7e357b
    Giedrius Statkevičius authored
    parse_arg() duplicates the funcionality of kstrtoint() so use the latter
    function instead. There is no funcionality change except that in the
    case of input being too big -ERANGE will be returned instead of -EINVAL
    which is not bad because -ERANGE makes more sense here. The check for
    !count is already done by the sysfs core so no need to duplicate it
    again. Also, add some minor corrections to error handling to accommodate
    the change in return values (parse_arg returned count if everything
    succeeded whereas kstrtoint returns 0 in the same situation)
    
    As a result of this patch asus-laptop.ko size is reduced by almost 1%:
    add/remove: 0/1 grow/shrink: 1/6 up/down: 1/-149 (-148)
    function                                     old     new   delta
    __UNIQUE_ID_vermagic0                         69      70      +1
    ls_switch_store                              133     117     -16
    ledd_store                                   175     159     -16
    display_store                                157     141     -16
    ls_level_store                               193     176     -17
    gps_store                                    200     178     -22
    sysfs_acpi_set.isra                          148     125     -23
    parse_arg.part                                39       -     -39
    Total: Before=19160, After=19012, chg -0.77%
    Signed-off-by: default avatarGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
    Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
    6f7e357b
asus-laptop.c 52.3 KB