• Bhupesh Sharma's avatar
    crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo · 1d50e5d0
    Bhupesh Sharma authored
    Right now user-space tools like 'makedumpfile' and 'crash' need to rely
    on a best-guess method of determining value of 'MAX_PHYSMEM_BITS'
    supported by underlying kernel.
    
    This value is used in user-space code to calculate the bit-space
    required to store a section for SPARESMEM (similar to the existing
    calculation method used in the kernel implementation):
    
      #define SECTIONS_SHIFT    (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS)
    
    Now, regressions have been reported in user-space utilities
    like 'makedumpfile' and 'crash' on arm64, with the recently added
    kernel support for 52-bit physical address space, as there is
    no clear method of determining this value in user-space
    (other than reading kernel CONFIG flags).
    
    As per suggestion from makedumpfile maintainer (Kazu), it makes more
    sense to append 'MAX_PHYSMEM_BITS' to vmcoreinfo in the core code itself
    rather than in arch-specific code, so that the user-space code for other
    archs can also benefit from this addition to the vmcoreinfo and use it
    as a standard way of determining 'SECTIONS_SHIFT' value in user-land.
    
    A reference 'makedumpfile' implementation which reads the
    'MAX_PHYSMEM_BITS' value from vmcoreinfo in a arch-independent fashion
    is available here:
    
    While at it also update vmcoreinfo documentation for 'MAX_PHYSMEM_BITS'
    variable being added to vmcoreinfo.
    
    'MAX_PHYSMEM_BITS' defines the maximum supported physical address
    space memory.
    Signed-off-by: default avatarBhupesh Sharma <bhsharma@redhat.com>
    Tested-by: default avatarJohn Donnelly <john.p.donnelly@oracle.com>
    Acked-by: default avatarDave Young <dyoung@redhat.com>
    Cc: Boris Petkov <bp@alien8.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: James Morse <james.morse@arm.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Will Deacon <will@kernel.org>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: Dave Anderson <anderson@redhat.com>
    Cc: Kazuhito Hagio <k-hagio@ab.jp.nec.com>
    Cc: x86@kernel.org
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-kernel@vger.kernel.org
    Cc: kexec@lists.infradead.org
    Link: https://lore.kernel.org/r/1589395957-24628-2-git-send-email-bhsharma@redhat.comSigned-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    1d50e5d0
crash_core.c 11.5 KB