• Bjorn Helgaas's avatar
    igb: Remove redundant runtime resume for ethtool_ops · 461359c4
    Bjorn Helgaas authored
    749ab2cd ("igb: add basic runtime PM support") added
    ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to
    resume suspended devices before any ethtool_ops callback and allow suspend
    after it completed.
    
    Subsequently, f32a2137 ("ethtool: runtime-resume netdev parent before
    ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path,
    so the device is resumed before any ethtool_ops callback even if the driver
    didn't supply a .begin() callback.
    
    Remove the .begin() and .complete() callbacks, which are now redundant
    because dev_ethtool() already resumes the device.
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: default avatarSimon Horman <horms@kernel.org>
    Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    461359c4
igb_ethtool.c 97.4 KB