• Darrick J. Wong's avatar
    xfs: minimize overhead of drain wakeups by using jump labels · 466c525d
    Darrick J. Wong authored
    To reduce the runtime overhead even further when online fsck isn't
    running, use a static branch key to decide if we call wake_up on the
    drain.  For compilers that support jump labels, the call to wake_up is
    replaced by a nop sled when nobody is waiting for intents to drain.
    
    From my initial microbenchmarking, every transition of the static key
    between the on and off states takes about 22000ns to complete; this is
    paid entirely by the xfs_scrub process.  When the static key is off
    (which it should be when fsck isn't running), the nop sled adds an
    overhead of approximately 0.36ns to runtime code.  The post-atomic
    lockless waiter check adds about 0.03ns, which is basically free.
    
    For the few compilers that don't support jump labels, runtime code pays
    the cost of calling wake_up on an empty waitqueue, which was observed to
    be about 30ns.  However, most architectures that have sufficient memory
    and CPU capacity to run XFS also support jump labels, so this is not
    much of a worry.
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    466c525d
ialloc.c 18.2 KB