• David Hildenbrand's avatar
    mm/migrate: convert do_pages_stat_array() from follow_page() to folio_walk · 46d6a9b4
    David Hildenbrand authored
    Let's use folio_walk instead, so we can avoid taking a folio reference
    just to read the nid and get rid of another follow_page()/FOLL_DUMP user. 
    Use FW_ZEROPAGE so we can return "-EFAULT" for it as documented.
    
    The possible return values for follow_page() were confusing, especially
    with FOLL_DUMP set.  We'll handle it like documented in the man page:
    
    * -EFAULT: This is a zero page or the memory area is not mapped by the
       process.
    * -ENOENT: The page is not present.
    
    We'll keep setting -ENOENT for ZONE_DEVICE.  Maybe not the right thing to
    do, but it likely doesn't really matter (just like for weird devmap,
    whereby we fake "not present").
    
    Note that the other errors (-EACCESS, -EBUSY, -EIO, -EINVAL, -ENOMEM) so
    far only applied when actually moving pages, not when only querying stats.
    
    We'll effectively drop the "secretmem" check we had in follow_page(), but
    that shouldn't really matter here, we're not accessing folio/page content
    after all.
    
    Link: https://lkml.kernel.org/r/20240802155524.517137-4-david@redhat.comSigned-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Cc: Alexander Gordeev <agordeev@linux.ibm.com>
    Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
    Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
    Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
    Cc: Heiko Carstens <hca@linux.ibm.com>
    Cc: Janosch Frank <frankja@linux.ibm.com>
    Cc: Jonathan Corbet <corbet@lwn.net>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Sven Schnelle <svens@linux.ibm.com>
    Cc: Vasily Gorbik <gor@linux.ibm.com>
    Cc: Ryan Roberts <ryan.roberts@arm.com>
    Cc: Zi Yan <ziy@nvidia.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    46d6a9b4
migrate.c 71.2 KB