• Jakub Kicinski's avatar
    ptp: improve max_adj check against unreasonable values · 475b92f9
    Jakub Kicinski authored
    Scaled PPM conversion to PPB may (on 64bit systems) result
    in a value larger than s32 can hold (freq/scaled_ppm is a long).
    This means the kernel will not correctly reject unreasonably
    high ->freq values (e.g. > 4294967295ppb, 281474976645 scaled PPM).
    
    The conversion is equivalent to a division by ~66 (65.536),
    so the value of ppb is always smaller than ppm, but not small
    enough to assume narrowing the type from long -> s32 is okay.
    
    Note that reasonable user space (e.g. ptp4l) will not use such
    high values, anyway, 4289046510ppb ~= 4.3x, so the fix is
    somewhat pedantic.
    
    Fixes: d39a7435 ("ptp: validate the requested frequency adjustment.")
    Fixes: d94ba80e ("ptp: Added a brand new class driver for ptp clocks.")
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    Acked-by: default avatarRichard Cochran <richardcochran@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    475b92f9
ptp_clock.c 9.89 KB