• Borislav Petkov's avatar
    sb_edac: Fix detection on SNB machines · 11249e73
    Borislav Petkov authored
    d0585cd8 ("sb_edac: Claim a different PCI device") changed the
    probing of sb_edac to look for PCI device 0x3ca0:
    
    3f:0e.0 System peripheral: Intel Corporation Xeon E5/Core i7 Processor Home Agent (rev 07)
    00: 86 80 a0 3c 00 00 00 00 07 00 80 08 00 00 80 00
    ...
    
    but we're matching for 0x3ca8, i.e. PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_TA
    in sbridge_probe() therefore the probing fails.
    
    Changing it to probe for 0x3ca0 (PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_HA0),
    .i.e., the 14.0 device, fixes the issue and driver loads successfully
    again:
    
    [ 2449.013120] EDAC DEBUG: sbridge_init:
    [ 2449.017029] EDAC sbridge: Seeking for: PCI ID 8086:3ca0
    [ 2449.022368] EDAC DEBUG: sbridge_get_onedevice: Detected 8086:3ca0
    [ 2449.028498] EDAC sbridge: Seeking for: PCI ID 8086:3ca0
    [ 2449.033768] EDAC sbridge: Seeking for: PCI ID 8086:3ca8
    [ 2449.039028] EDAC DEBUG: sbridge_get_onedevice: Detected 8086:3ca8
    [ 2449.045155] EDAC sbridge: Seeking for: PCI ID 8086:3ca8
    ...
    
    Add a debug printk while at it to be able to catch the failure in the
    future and dump driver version on successful load.
    
    Fixes: d0585cd8 ("sb_edac: Claim a different PCI device")
    Cc: stable@vger.kernel.org # 3.18
    Acked-by: default avatarAristeu Rozanski <aris@redhat.com>
    Cc: Tony Luck <tony.luck@intel.com>
    Acked-by: default avatarAndy Lutomirski <luto@amacapital.net>
    Acked-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    11249e73
sb_edac.c 65.9 KB