• Brice Goglin's avatar
    [PATCH] increment pos before looking for the next cap in __pci_find_next_ht_cap · 47a4d5be
    Brice Goglin authored
    While testing 2.6.20-rc3 on a machine with some CK804 chipsets, we noticed
    that quirk_nvidia_ck804_msi_ht_cap() was not detecting HT MSI capabilities
    anymore.  It is actually caused by the MSI mapping on the root chipset
    being the 2nd HT capability in the chain.  pci_find_ht_capability() does
    not seem to find anything but the first HT cap correctly, because it
    forgets to increment the position before looking for the next cap.  The
    following patch seems to fix it.
    
    At least, this proves that having a ttl is good idea since the machine
    would have been stucked in an infinite loop if we didn't have a ttl :)
    
    We have to pass pos + PCI_CAP_LIST_NEXT to __pci_find_next_cap_ttl to
    get the next HT cap instead of the same one again.
    Signed-off-by: default avatarBrice Goglin <brice@myri.com>
    Signed-off-by: default avatarAndrew J. Gallatin <gallatin@myri.com>
    Cc: Greg KH <greg@kroah.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    47a4d5be
pci.c 31.4 KB