• Mika Westerberg's avatar
    pinctrl: cherryview: Do not add all southwest and north GPIOs to IRQ domain · 47c950d1
    Mika Westerberg authored
    It turns out that for north and southwest communities, they can only
    generate GPIO interrupts for lower 8 interrupts (IntSel value). The upper
    part (8-15) can only generate GPEs (General Purpose Events).
    
    Now the reason why EC events such as pressing hotkeys does not work if we
    mask all the interrupts is that in order to generate either interrupts or
    GPEs the INTMASK register must have that particular interrupt unmasked. In
    case of GPEs the CPU does not trigger normal interrupt (and thus the GPIO
    driver does not see it) but instead it causes SCI (System Control
    Interrupt) to be triggered with the GPE in question set.
    
    To make this all work as expected we only add those GPIOs to the IRQ domain
    that can actually generate interrupts (IntSel value 0-7) and skip others.
    Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    47c950d1
pinctrl-cherryview.c 48.6 KB