• Johannes Weiner's avatar
    rtc-x1205: fix rtc_time to y2k register value conversion · 48a7f774
    Johannes Weiner authored
    The possible CCR_Y2K register values are 19 or 20 and struct rtc_time's
    tm_year is in years since 1900.
    
    The function translating rtc_time to register values assumes tm_year to be
    years since first christmas, though, and we end up storing 0 or 1 in the
    CCR_Y2K register, which the hardware does not refuse to do.
    
    A subsequent probing of the clock fails due to the invalid value range in
    the register, though.
    
    [ And if it didn't, reading the clock would yield a bogus year because
      the function translating registers to tm_year is assuming a register
      value of 19 or 20. ]
    
    This fixes the conversion from years since 1900 in tm_year to the
    corresponding CCR_Y2K value of 19 or 20.
    Signed-off-by: default avatarJohannes Weiner <jw@emlix.com>
    Cc: Alessandro Zummo <a.zummo@towertech.it>
    Cc: Paul Gortmaker <p_gortmaker@yahoo.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    48a7f774
rtc-x1205.c 16 KB