• Julia Lawall's avatar
    spi/amba-pl022: Fix error case return statement. · 4a4fd471
    Julia Lawall authored
    The return -EINVAL appears to only make sense if the if branch that it is
    aligned with is taken, and the indentation indicates that this is the
    authors intent, so move it into that branch.
    
    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r disable braces4@
    position p1,p2;
    statement S1,S2;
    @@
    
    (
    if (...) { ... }
    |
    if (...) S1@p1 S2@p2
    )
    
    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@
    
    if (p1[0].column == p2[0].column):
      cocci.print_main("branch",p1)
      cocci.print_secs("after",p2)
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
    4a4fd471
amba-pl022.c 56.3 KB