• Will Deacon's avatar
    arm64: KVM: Add braces to multi-line if statement in virtual PMU code · 7d4bd1d2
    Will Deacon authored
    The kernel is written in C, not python, so we need braces around
    multi-line if statements. GCC 6 actually warns about this, thanks to the
    fantastic new "-Wmisleading-indentation" flag:
    
     | virt/kvm/arm/pmu.c: In function ‘kvm_pmu_overflow_status’:
     | virt/kvm/arm/pmu.c:198:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
     |    reg &= vcpu_sys_reg(vcpu, PMCNTENSET_EL0);
     |    ^~~
     | arch/arm64/kvm/../../../virt/kvm/arm/pmu.c:196:2: note: ...this ‘if’ clause, but it is not
     |   if ((vcpu_sys_reg(vcpu, PMCR_EL0) & ARMV8_PMU_PMCR_E))
     |   ^~
    
    As it turns out, this particular case is harmless (we just do some &=
    operations with 0), but worth fixing nonetheless.
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    Signed-off-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
    7d4bd1d2
pmu.c 13.1 KB