• Roberto Sassu's avatar
    evm: Introduce evm_hmac_disabled() to safely ignore verification errors · 4a804b8a
    Roberto Sassu authored
    When a file is being created, LSMs can set the initial label with the
    inode_init_security hook. If no HMAC key is loaded, the new file will have
    LSM xattrs but not the HMAC. It is also possible that the file remains
    without protected xattrs after creation if no active LSM provided it, or
    because the filesystem does not support them.
    
    Unfortunately, EVM will deny any further metadata operation on new files,
    as evm_protect_xattr() will return the INTEGRITY_NOLABEL error if protected
    xattrs exist without security.evm, INTEGRITY_NOXATTRS if no protected
    xattrs exist or INTEGRITY_UNKNOWN if xattrs are not supported. This would
    limit the usability of EVM when only a public key is loaded, as commands
    such as cp or tar with the option to preserve xattrs won't work.
    
    This patch introduces the evm_hmac_disabled() function to determine whether
    or not it is safe to ignore verification errors, based on the ability of
    EVM to calculate HMACs. If the HMAC key is not loaded, and it cannot be
    loaded in the future due to the EVM_SETUP_COMPLETE initialization flag,
    allowing an operation despite the attrs/xattrs being found invalid will not
    make them valid.
    
    Since the post hooks can be executed even when the HMAC key is not loaded,
    this patch also ensures that the EVM_INIT_HMAC initialization flag is set
    before the post hooks call evm_update_evmxattr().
    Signed-off-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
    Suggested-by: Mimi Zohar <zohar@linux.ibm.com> (for ensuring EVM_INIT_HMAC is set)
    Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
    4a804b8a
evm_main.c 17.7 KB