• Xiu Jianfeng's avatar
    Revert "evm: Fix memleak in init_desc" · 51dd64bb
    Xiu Jianfeng authored
    This reverts commit ccf11dba.
    
    Commit ccf11dba ("evm: Fix memleak in init_desc") said there is
    memleak in init_desc. That may be incorrect, as we can see, tmp_tfm is
    saved in one of the two global variables hmac_tfm or evm_tfm[hash_algo],
    then if init_desc is called next time, there is no need to alloc tfm
    again, so in the error path of kmalloc desc or crypto_shash_init(desc),
    It is not a problem without freeing tmp_tfm.
    
    And also that commit did not reset the global variable to NULL after
    freeing tmp_tfm and this makes *tfm a dangling pointer which may cause a
    UAF issue.
    Reported-by: default avatarGuozihua (Scott) <guozihua@huawei.com>
    Signed-off-by: default avatarXiu Jianfeng <xiujianfeng@huawei.com>
    Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
    51dd64bb
evm_crypto.c 10.8 KB