• Jon Maloy's avatar
    tipc: initialize broadcast link stale counter correctly · 4af00f4c
    Jon Maloy authored
    In the commit referred to below we added link tolerance as an additional
    criteria for declaring broadcast transmission "stale" and resetting the
    unicast links to the affected node.
    
    Unfortunately, this 'improvement' introduced two bugs, which each and
    one alone cause only limited problems, but combined lead to seemingly
    stochastic unicast link resets, depending on the amount of broadcast
    traffic transmitted.
    
    The first issue, a missing initialization of the 'tolerance' field of
    the receiver broadcast link, was recently fixed by commit 047491ea
    ("tipc: set link tolerance correctly in broadcast link").
    
    Ths second issue, where we omit to reset the 'stale_cnt' field of
    the same link after a 'stale' period is over, leads to this counter
    accumulating over time, and in the absence of the 'tolerance' criteria
    leads to the above described symptoms. This commit adds the missing
    initialization.
    
    Fixes: a4dc70d4 ("tipc: extend link reset criteria for stale packet retransmission")
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Acked-by: default avatarYing Xue <ying.xue@windriver.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4af00f4c
link.c 60 KB