• Kees Cook's avatar
    overflow: Introduce overflows_type() and castable_to_type() · 4b21d25b
    Kees Cook authored
    Implement a robust overflows_type() macro to test if a variable or
    constant value would overflow another variable or type. This can be
    used as a constant expression for static_assert() (which requires a
    constant expression[1][2]) when used on constant values. This must be
    constructed manually, since __builtin_add_overflow() does not produce
    a constant expression[3].
    
    Additionally adds castable_to_type(), similar to __same_type(), but for
    checking if a constant value would overflow if cast to a given type.
    
    Add unit tests for overflows_type(), __same_type(), and castable_to_type()
    to the existing KUnit "overflow" test:
    
    [16:03:33] ================== overflow (21 subtests) ==================
    ...
    [16:03:33] [PASSED] overflows_type_test
    [16:03:33] [PASSED] same_type_test
    [16:03:33] [PASSED] castable_to_type_test
    [16:03:33] ==================== [PASSED] overflow =====================
    [16:03:33] ============================================================
    [16:03:33] Testing complete. Ran 21 tests: passed: 21
    [16:03:33] Elapsed time: 24.022s total, 0.002s configuring, 22.598s building, 0.767s running
    
    [1] https://en.cppreference.com/w/c/language/_Static_assert
    [2] C11 standard (ISO/IEC 9899:2011): 6.7.10 Static assertions
    [3] https://gcc.gnu.org/onlinedocs/gcc/Integer-Overflow-Builtins.html
        6.56 Built-in Functions to Perform Arithmetic with Overflow Checking
        Built-in Function: bool __builtin_add_overflow (type1 a, type2 b,
    
    Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
    Cc: Nathan Chancellor <nathan@kernel.org>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Cc: Tom Rix <trix@redhat.com>
    Cc: Daniel Latypov <dlatypov@google.com>
    Cc: Vitor Massaru Iha <vitor@massaru.org>
    Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    Cc: linux-hardening@vger.kernel.org
    Cc: llvm@lists.linux.dev
    Co-developed-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
    Signed-off-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Link: https://lore.kernel.org/r/20221024201125.1416422-1-gwan-gyeong.mun@intel.com
    4b21d25b
overflow_kunit.c 43.9 KB