• Harvey Hunt's avatar
    irqchip/mips-gic: Fix IRQs in gic_dev_domain · 4b2312bd
    Harvey Hunt authored
    When allocating a new device IRQ, gic_dev_domain_alloc() correctly calls
    irq_domain_set_hwirq_and_chip(), but gic_irq_domain_alloc() does not. This
    means that gic_irq_domain believes all IRQs from the dev domain have an
    hwirq of 0 and creates incorrect mappings in the linear_revmap. As
    gic_irq_domain is a parent of the gic_dev_domain, this leads to an
    inability to boot on devices with a GIC. Excerpt of the error:
    
    [    2.297649] irq 0: nobody cared (try booting with the "irqpoll" option)
    ...
    [    2.436963] handlers:
    [    2.439492] Disabling IRQ #0
    
    Fix this by calling irq_domain_set_hwirq_and_chip() for both the dev and
    irq domain.
    
    Now that we are modifying the parent domain, be sure to clear it up in
    case of an allocation error.
    
    Fixes: c98c1822 ("irqchip/mips-gic: Add device hierarchy domain")
    Fixes: 2af70a96 ("irqchip/mips-gic: Add a IPI hierarchy domain")
    Signed-off-by: default avatarHarvey Hunt <harvey.hunt@imgtec.com>
    Tested-by: Govindraj Raja <Govindraj.Raja@imgtec.com> # On Pistachio SoC
    Reviewed-by: default avatarMatt Redfearn <matt.redfearn@imgtec.com>
    Cc: linux-mips@linux-mips.org
    Cc: Qais Yousef <qsyousef@gmail.com>
    Cc: jason@lakedaemon.net
    Cc: marc.zyngier@arm.com
    Cc: stable@vger.kernel.org
    Link: http://lkml.kernel.org/r/1464001552-31174-1-git-send-email-harvey.hunt@imgtec.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    4b2312bd
irq-mips-gic.c 27.7 KB