• Nathan Chancellor's avatar
    drm/i915: Clean up disabled warnings · 4b2437f6
    Nathan Chancellor authored
    i915 enables a wider set of warnings with '-Wall -Wextra' then disables
    several with cc-disable-warning. If an unknown flag gets added to
    KBUILD_CFLAGS when building with clang, all subsequent calls to
    cc-{disable-warning,option} will fail, meaning that all of these
    warnings do not get disabled [1].
    
    A separate series will address the root cause of the issue by not adding
    these flags when building with clang [2]; however, the symptom of these
    extra warnings appearing can be addressed separately by just removing
    the calls to cc-disable-warning, which makes the build ever so slightly
    faster because the compiler does not need to be called as much before
    building.
    
    The following warnings are supported by GCC 4.9 and clang 10.0.1, which
    are the minimum supported versions of these compilers so the call to
    cc-disable-warning is not necessary. Masahiro cleaned this up for the
    reset of the kernel in commit 4c8dd95a ("kbuild: add some extra
    warning flags unconditionally").
    
    * -Wmissing-field-initializers
    * -Wsign-compare
    * -Wtype-limits
    * -Wunused-parameter
    
    -Wunused-but-set-variable was implemented in clang 13.0.0 and
    -Wframe-address was implemented in clang 12.0.0 so the
    cc-disable-warning calls are kept for these two warnings.
    
    Lastly, -Winitializer-overrides is clang's version of -Woverride-init,
    which is disabled for the specific files that are problematic. clang
    added a compatibility alias in clang 8.0.0 so -Winitializer-overrides
    can be removed.
    
    [1]: https://lore.kernel.org/r/202108210311.CBtcgoUL-lkp@intel.com/
    [2]: https://lore.kernel.org/r/20210824022640.2170859-1-nathan@kernel.org/Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210914194944.4004260-1-nathan@kernel.org
    4b2437f6
Makefile 8.38 KB