• Chen-Yu Tsai's avatar
    drm/sun4i: Fix TCON clock and regmap initialization sequence · 4c7f16d1
    Chen-Yu Tsai authored
    The TCON driver calls sun4i_tcon_init_regmap and sun4i_tcon_init_clocks
    in its bind function. The former creates a regmap and writes to several
    register to clear its configuration to a known default. The latter
    initializes various clocks. This includes enabling the bus clock for
    register access and creating the dotclock.
    
    In order for the first step's writes to work, the bus clock must be
    enabled which is done in the second step. but the dotclock's ops use
    the regmap created in the first step.
    
    Rearrange the function calls such that the clocks are initialized before
    the regmap, and split out the dot clock creation to after the regmap is
    initialized.
    
    Fixes: 9026e0d1 ("drm: Add Allwinner A10 Display Engine support")
    Signed-off-by: default avatarChen-Yu Tsai <wens@csie.org>
    Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
    4c7f16d1
sun4i_tcon.c 16.6 KB